linux-kernel - Re: [PATCH v6 2/2] media: aspeed: Allow to capture from SoC display (GFX)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51d48faf-9f62-431f-b1bf-b78f0a30ae14@kernel.org>
Date: Thu, 29 Aug 2024 09:56:18 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jammy Huang <jammy_huang@...eedtech.com>, robh@...nel.org,
 conor+dt@...nel.org, eajames@...ux.ibm.com, mchehab@...nel.org,
 joel@....id.au, andrew@...id.au, hverkuil@...all.nl, pmenzel@...gen.mpg.de,
 krzk+dt@...nel.org
Cc: devicetree@...r.kernel.org, linux-media@...r.kernel.org,
 openbmc@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org,
 linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/2] media: aspeed: Allow to capture from SoC display
 (GFX)

On 29/08/2024 08:45, Jammy Huang wrote:
> ASPEED BMC IC has 2 different display engines. Please find AST2600's
> datasheet to get detailed information.
> 

...

>  
> +/*
> + * Get regmap without checking res, such as clk/reset, that could lead to
> + * conflict.
> + */
> +static struct regmap *aspeed_regmap_lookup(struct device_node *np, const char *property)
> +{
> +	struct device_node *syscon_np __free(device_node) = of_parse_phandle(np, property, 0);
> +
> +	if (!syscon_np)
> +		return ERR_PTR(-ENODEV);
> +
> +	return device_node_to_regmap(syscon_np);
> +}
> +
>  static int aspeed_video_init(struct aspeed_video *video)
>  {
>  	int irq;
>  	int rc;
>  	struct device *dev = video->dev;
>  
> +	video->scu = aspeed_regmap_lookup(dev->of_node, "aspeed,scu");
> +	video->gfx = aspeed_regmap_lookup(dev->of_node, "aspeed,gfx");

So that's a new property? Not related to conversion? Then split the
patches. Conversion is one logical change. Adding properties for new
hardware is completely different.

Best regards,
Krzysztof