linux-kernel - Re: [PATCH v2 08/14] mm: copy_pte_range() use pte_offset_map_rw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <A619C874-E6B9-4D07-82B9-ABBCDB39DFC2@linux.dev>
Date: Thu, 29 Aug 2024 16:13:44 +0800
From: Muchun Song <muchun.song@...ux.dev>
To: Qi Zheng <zhengqi.arch@...edance.com>
Cc: David Hildenbrand <david@...hat.com>,
 Hugh Dickins <hughd@...gle.com>,
 Matthew Wilcox <willy@...radead.org>,
 "Vlastimil Babka (SUSE)" <vbabka@...nel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Mike Rapoport <rppt@...nel.org>,
 Vishal Moola <vishal.moola@...il.com>,
 Peter Xu <peterx@...hat.com>,
 Ryan Roberts <ryan.roberts@....com>,
 christophe.leroy2@...soprasteria.com,
 LKML <linux-kernel@...r.kernel.org>,
 Linux Memory Management List <linux-mm@...ck.org>,
 linux-arm-kernel@...ts.infradead.org,
 linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v2 08/14] mm: copy_pte_range() use
 pte_offset_map_rw_nolock()



> On Aug 22, 2024, at 15:13, Qi Zheng <zhengqi.arch@...edance.com> wrote:
> 
> In copy_pte_range(), we may modify the src_pte entry after holding the
> src_ptl, so convert it to using pte_offset_map_rw_nolock(). But since we
> already hold the write lock of mmap_lock, there is no need to get pmdval
> to do pmd_same() check, just pass a dummy variable to it.
> 
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>

Reviewed-by: Muchun Song <muchun.song@...ux.dev>