linux-kernel - Re: [PATCH v2 2/2] bus: bt1-apb: change to use devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <y6wsowxr6my2kslhzt3iq6cwwu2gu65cdiwwrxhbkqmpmbmdqk@vhm5t54e3cdo>
Date: Thu, 29 Aug 2024 11:25:11 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: Wu Bo <bo.wu@...o.com>
Cc: linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org, 
	wubo.oduw@...il.com
Subject: Re: [PATCH v2 2/2] bus: bt1-apb: change to use
 devm_clk_get_enabled() helper

On Mon, Aug 26, 2024 at 08:53:58PM -0600, Wu Bo wrote:
> Use devm_clk_get_enabled() instead of devm_clk_get() to make the code
> cleaner and avoid calling clk_disable_unprepare()

Great! Thanks.
Acked-by: Serge Semin <fancer.lancer@...il.com>

-Serge(y)

> 
> Signed-off-by: Wu Bo <bo.wu@...o.com>
> ---
>  drivers/bus/bt1-apb.c | 23 +----------------------
>  1 file changed, 1 insertion(+), 22 deletions(-)
> 
> diff --git a/drivers/bus/bt1-apb.c b/drivers/bus/bt1-apb.c
> index 595fb22b73e0..7463124b6dd9 100644
> --- a/drivers/bus/bt1-apb.c
> +++ b/drivers/bus/bt1-apb.c
> @@ -185,34 +185,13 @@ static int bt1_apb_request_rst(struct bt1_apb *apb)
>  	return ret;
>  }
>  
> -static void bt1_apb_disable_clk(void *data)
> -{
> -	struct bt1_apb *apb = data;
> -
> -	clk_disable_unprepare(apb->pclk);
> -}
> -
>  static int bt1_apb_request_clk(struct bt1_apb *apb)
>  {
> -	int ret;
> -
> -	apb->pclk = devm_clk_get(apb->dev, "pclk");
> +	apb->pclk = devm_clk_get_enabled(apb->dev, "pclk");
>  	if (IS_ERR(apb->pclk))
>  		return dev_err_probe(apb->dev, PTR_ERR(apb->pclk),
>  				     "Couldn't get APB clock descriptor\n");
>  
> -	ret = clk_prepare_enable(apb->pclk);
> -	if (ret) {
> -		dev_err(apb->dev, "Couldn't enable the APB clock\n");
> -		return ret;
> -	}
> -
> -	ret = devm_add_action_or_reset(apb->dev, bt1_apb_disable_clk, apb);
> -	if (ret) {
> -		dev_err(apb->dev, "Can't add APB EHB clocks disable action\n");
> -		return ret;
> -	}
> -
>  	apb->rate = clk_get_rate(apb->pclk);
>  	if (!apb->rate) {
>  		dev_err(apb->dev, "Invalid clock rate\n");
> -- 
> 2.25.1
>