linux-kernel - RE: [PATCH -next 1/3] media: v4l2-subdev: enable module autoloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB11346459841445E77A5FBA37B86962@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Thu, 29 Aug 2024 08:27:06 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Liao Chen <liaochen4@...wei.com>, "linux-tegra@...r.kernel.org"
	<linux-tegra@...r.kernel.org>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
	"mchehab@...nel.org" <mchehab@...nel.org>, "thierry.reding@...il.com"
	<thierry.reding@...il.com>, "jonathanh@...dia.com" <jonathanh@...dia.com>,
	"jacopo@...ndi.org" <jacopo@...ndi.org>, "sakari.ailus@...ux.intel.com"
	<sakari.ailus@...ux.intel.com>, "laurent.pinchart@...asonboard.com"
	<laurent.pinchart@...asonboard.com>, "tomi.valkeinen@...asonboard.com"
	<tomi.valkeinen@...asonboard.com>
Subject: RE: [PATCH -next 1/3] media: v4l2-subdev: enable module autoloading

Hi Liao Chen,

Thanks for the patch.

> -----Original Message-----
> From: Liao Chen <liaochen4@...wei.com>
> Sent: Thursday, August 29, 2024 8:54 AM
> Subject: [PATCH -next 1/3] media: v4l2-subdev: enable module autoloading

Commit header is wrong.

> 
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based on the alias from
> of_device_id table.
> 
> Signed-off-by: Liao Chen <liaochen4@...wei.com>
> ---
>  drivers/media/i2c/mt9v111.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c index
> b0b98ed3c150..b6a2623798c5 100644
> --- a/drivers/media/i2c/mt9v111.c
> +++ b/drivers/media/i2c/mt9v111.c
> @@ -1265,6 +1265,7 @@ static const struct of_device_id mt9v111_of_match[] = {
>  	{ .compatible = "aptina,mt9v111", },
>  	{ /* sentinel */ },

Nit: Comma can be dropped from terminator entry as a separate patch.

Cheers,
Biju

>  };
> +MODULE_DEVICE_TABLE(of, mt9v111_of_match);
> 
>  static struct i2c_driver mt9v111_driver = {
>  	.driver = {
> --
> 2.34.1