linux-kernel - Re: [PATCH] mips: Remove posix_types.h include from sigcontext.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtA2CjzGY9CK6jPh@alpha.franken.de>
Date: Thu, 29 Aug 2024 10:49:14 +0200
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Xi Ruoyao <xry111@...111.site>
Cc: Jiaxun Yang <jiaxun.yang@...goat.com>, linux-mips@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mips: Remove posix_types.h include from sigcontext.h

On Wed, Aug 28, 2024 at 11:04:14AM +0800, Xi Ruoyao wrote:
> Nothing in sigcontext.h seems to require anything from
> linux/posix_types.h.
> 
> It seems only a relict: in a Linux 2.6.11-rc2 patch [1] the
> linux/types.h include was unexplainedly changed to a linux/posix_types.h
> include.  I can only assume it was just an error.  Finally headers_check
> complained "found __[us]{8,16,32,64} type without #include
> <linux/types.h>" and commit ae612fb05b0f ("headers_check fix: mips,
> sigcontext.h") added back the linux/types.h include, but it didn't
> remove the posix_types.h include.
> 
> Remove it now.
> 
> [1]:https://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc2/2.6.11-rc2-mm2/broken-out/mips-generic-mips-updates.patch
> 
> Signed-off-by: Xi Ruoyao <xry111@...111.site>
> ---
>  arch/mips/include/uapi/asm/sigcontext.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/include/uapi/asm/sigcontext.h b/arch/mips/include/uapi/asm/sigcontext.h
> index d0a540e88bb4..d10afd13ee5b 100644
> --- a/arch/mips/include/uapi/asm/sigcontext.h
> +++ b/arch/mips/include/uapi/asm/sigcontext.h
> @@ -56,7 +56,6 @@ struct sigcontext {
>  
>  #if _MIPS_SIM == _MIPS_SIM_ABI64 || _MIPS_SIM == _MIPS_SIM_NABI32
>  
> -#include <linux/posix_types.h>
>  /*
>   * Keep this struct definition in sync with the sigcontext fragment
>   * in arch/mips/kernel/asm-offsets.c
> -- 
> 2.46.0

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]