linux-kernel - Re: [net-next PATCH v7 1/8] octeontx2-pf: map skb data as device writeable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240828182140.18e386c3@kernel.org>
Date: Wed, 28 Aug 2024 18:21:40 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Bharat Bhushan <bbhushan2@...vell.com>
Cc: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <sgoutham@...vell.com>, <gakula@...vell.com>, <sbhatta@...vell.com>,
 <hkelam@...vell.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <jerinj@...vell.com>, <lcherian@...vell.com>,
 <richardcochran@...il.com>, <bharatb.linux@...il.com>
Subject: Re: [net-next PATCH v7 1/8] octeontx2-pf: map skb data as device
 writeable

On Tue, 27 Aug 2024 19:02:03 +0530 Bharat Bhushan wrote:
> Crypto hardware need write permission for in-place encrypt
> or decrypt operation on skb-data to support IPsec crypto
> offload. That patch uses skb_unshare to make sdk data writeable

sdk -> skb ? :(

> for ipsec crypto offload and map skb fragment memory as
> device read-write.

Does the crypto engine always override the data with ciphertext?
How did you test this prior to adding skb_unshare()?
Could you share some performance data with this change?