lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240829091134.rf2fcyqxoxapulbe@quack3>
Date: Thu, 29 Aug 2024 11:11:34 +0200
From: Jan Kara <jack@...e.cz>
To: zhangshida <starzhangzsd@...il.com>
Cc: tytso@....edu, adilger.kernel@...ger.ca, jack@...e.com,
	ebiggers@...nel.org, linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org, zhangshida@...inos.cn,
	Jan Kara <jack@...e.cz>
Subject: Re: [PATCH 1/3] ext4: persist the new uptodate buffers in
 ext4_journalled_zero_new_buffers

On Thu 29-08-24 16:54:05, zhangshida wrote:
> From: Shida Zhang <zhangshida@...inos.cn>
> 
> For new uptodate buffers we also need to call write_end_fn() to persist the
> uptodate content, similarly as folio_zero_new_buffers() does it.
> 
> Suggested-by: Jan Kara <jack@...e.cz>
> Signed-off-by: Shida Zhang <zhangshida@...inos.cn>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext4/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 941c1c0d5c6e..a0a55cb8db53 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -1389,9 +1389,9 @@ static void ext4_journalled_zero_new_buffers(handle_t *handle,
>  					size = min(to, block_end) - start;
>  
>  					folio_zero_range(folio, start, size);
> -					write_end_fn(handle, inode, bh);
>  				}
>  				clear_buffer_new(bh);
> +				write_end_fn(handle, inode, bh);
>  			}
>  		}
>  		block_start = block_end;
> -- 
> 2.33.0
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ