linux-kernel - Re: [PATCH v2 1/6] math.h: Add macros for rounding to the closest value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bcddd10-6699-4e76-9eaf-8768f1c1ae66@kernel.org>
Date: Thu, 29 Aug 2024 11:54:41 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Jani Nikula <jani.nikula@...el.com>, Devarsh Thakkar <devarsht@...com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: mchehab@...nel.org, hverkuil-cisco@...all.nl,
 linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 sebastian.fricke@...labora.com, linux-doc@...r.kernel.org, praneeth@...com,
 nm@...com, vigneshr@...com, s-jain1@...com, r-donadkar@...com,
 b-brnich@...com, detheridge@...com, p-mantena@...com, vijayp@...com,
 andi.shyti@...ux.intel.com, nicolas@...fresne.ca, davidgow@...gle.com,
 dlatypov@...gle.com, corbet@....net, broonie@...nel.org,
 rdunlap@...radead.org, nik.borisov@...e.com, Dave.Martin@....com
Subject: Re: [PATCH v2 1/6] math.h: Add macros for rounding to the closest
 value

On 29. 08. 24, 11:19, Jani Nikula wrote:
> The stupid thing here is, I still don't remember which one is the
> generic thing, rounddown() or round_down(). I have to look it up every
> single time to be sure. I refuse to believe I'd be the only one.
> 
> It's okay to accidentally use the generic version, no harm done. It's
> definitely not okay to accidentally use the special pow-2 version, so it
> should have a special name. I think _pow2() or _pow_2() is a fine
> suffix.

Concur.

-- 
js
suse labs