linux-kernel - Re: [PATCH 2/2] regulator: qcom_spmi: Use of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6cqvluvuogkrx77x5q2neobxa4bu5tfxocdbdd6hlydqqqj2j4@opaxs554ehxs>
Date: Thu, 29 Aug 2024 13:09:23 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] regulator: qcom_spmi: Use of_property_read_bool()

On Wed, Aug 28, 2024 at 08:00:55AM GMT, Rob Herring (Arm) wrote:
> Use of_property_read_bool() to read boolean properties rather than
> of_find_property(). This is part of a larger effort to remove callers
> of of_find_property() and similar functions. of_find_property() leaks
> the DT property pointer which is a problem for dynamically allocated
> nodes which may be freed.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>  drivers/regulator/qcom_spmi-regulator.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

-- 
With best wishes
Dmitry