linux-kernel - Re: [PATCH 4/5] i2c: imx-lpi2c: improve i2c driver probe priority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fce999af-3613-4704-81a8-048159288b59@gmx.net>
Date: Thu, 29 Aug 2024 12:16:13 +0200
From: Stefan Wahren <wahrenst@....net>
To: carlos.song@....com, aisheng.dong@....com, andi.shyti@...nel.org,
 shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
 festevam@...il.com
Cc: linux-i2c@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] i2c: imx-lpi2c: improve i2c driver probe priority

Hi Carlos,

Am 29.08.24 um 11:37 schrieb carlos.song@....com:
> From: Carlos Song <carlos.song@....com>
>
> Some i2c devices such as PMICs need i2c bus available early.
> Use subsys_initcall to improve i2c driver probe priority.
thanks for providing this patch.

Please try to be more specific, which devices/platform has been effected
by this issue. It would be nice to provide to kind of
link/reference/discussion.

Best regards
>
> Signed-off-by: Carlos Song <carlos.song@....com>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>   drivers/i2c/busses/i2c-imx-lpi2c.c | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
> index 0159ade235ef..210d505db76d 100644
> --- a/drivers/i2c/busses/i2c-imx-lpi2c.c
> +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
> @@ -1487,7 +1487,17 @@ static struct platform_driver lpi2c_imx_driver = {
>   	},
>   };
>
> -module_platform_driver(lpi2c_imx_driver);
> +static int __init lpi2c_imx_init(void)
> +{
> +	return platform_driver_register(&lpi2c_imx_driver);
> +}
> +subsys_initcall(lpi2c_imx_init);
> +
> +static void __exit lpi2c_imx_exit(void)
> +{
> +	platform_driver_unregister(&lpi2c_imx_driver);
> +}
> +module_exit(lpi2c_imx_exit);
>
>   MODULE_AUTHOR("Gao Pan <pandy.gao@....com>");
>   MODULE_DESCRIPTION("I2C adapter driver for LPI2C bus");