linux-kernel - Re: [PATCH V5 net-next 04/11] net: hibmcge: Add interrupt supported in this module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240828183536.130df0fa@kernel.org>
Date: Wed, 28 Aug 2024 18:35:36 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <shenjian15@...wei.com>, <wangpeiyang1@...wei.com>,
 <liuyonglong@...wei.com>, <chenhao418@...wei.com>,
 <sudongming1@...wei.com>, <xujunsheng@...wei.com>,
 <shiyongbang@...wei.com>, <libaihan@...wei.com>, <andrew@...n.ch>,
 <jdamato@...tly.com>, <horms@...nel.org>, <jonathan.cameron@...wei.com>,
 <shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V5 net-next 04/11] net: hibmcge: Add interrupt supported
 in this module

On Tue, 27 Aug 2024 21:14:48 +0800 Jijie Shao wrote:
> +	ret = pci_alloc_irq_vectors(priv->pdev, HBG_VECTOR_NUM, HBG_VECTOR_NUM,
> +				    PCI_IRQ_MSI | PCI_IRQ_MSIX);

These are not devm_ -managed, don't you have to free them?
On remove and errors during probe?