linux-kernel - Re: [PATCH] cachefiles: fix dentry leak in cachefiles_open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <491c1962-1f9e-4aca-b263-eb6eb88140e0@huaweicloud.com>
Date: Thu, 29 Aug 2024 09:43:23 +0800
From: Baokun Li <libaokun@...weicloud.com>
To: David Howells <dhowells@...hat.com>
Cc: Markus Elfring <Markus.Elfring@....de>, netfs@...ts.linux.dev,
 linux-fsdevel@...r.kernel.org, linux-erofs@...ts.ozlabs.org,
 Jeff Layton <jlayton@...nel.org>, stable@...nel.org,
 LKML <linux-kernel@...r.kernel.org>, Christian Brauner <brauner@...nel.org>,
 Gao Xiang <hsiangkao@...ux.alibaba.com>, Hou Tao <houtao1@...wei.com>,
 Jingbo Xu <jefflexu@...ux.alibaba.com>, Yang Erkun <yangerkun@...wei.com>,
 Yu Kuai <yukuai3@...wei.com>, Zizhi Wo <wozizhi@...wei.com>,
 Baokun Li <libaokun@...weicloud.com>
Subject: Re: [PATCH] cachefiles: fix dentry leak in cachefiles_open_file()

Hi David,

On 2024/8/29 0:14, David Howells wrote:
> Baokun Li <libaokun@...weicloud.com> wrote:
>
>>> You couldn't do that anyway, since kernel_file_open() steals the caller's ref
>>> if successful.
>> Ignoring kernel_file_open(), we now put a reference count of the dentry
>> whether cachefiles_open_file() returns true or false.
> Actually, I'm wrong kernel_file_open() doesn't steal a ref.
>
> David
>
>
Thanks for confirming this.
I will send a new version using the new solution.


Cheers,
Baokun