linux-kernel - Re: [PATCH 0/2] Some boundary error bugfix related to XFS fsmap.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9337ebda-8e27-4754-bc57-748e44f3b5e0@huawei.com>
Date: Thu, 29 Aug 2024 19:24:55 +0800
From: Zizhi Wo <wozizhi@...wei.com>
To: <chandan.babu@...cle.com>, <djwong@...nel.org>, <dchinner@...hat.com>,
	<osandov@...com>, <john.g.garry@...cle.com>
CC: <linux-xfs@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<yangerkun@...wei.com>
Subject: Re: [PATCH 0/2] Some boundary error bugfix related to XFS fsmap.

friendly ping

在 2024/8/26 11:10, Zizhi Wo 写道:
> Prior to this, I had already sent out a patchset related to xfs fsmap
> bugfix, which mainly introduced "info->end_daddr" to fix omitted extents[1]
> and Darrick had already sent out a patchbomb for merging into stable[2],
> which included my previous patches.
> 
> However, I recently discovered two new fsmap problems...What follows is a
> brief description of them:
> 
> Patch 1: In this scenario, fsmap lost one block count. The root cause is
> that during the calculation of highkey, the calculation of start_block is
> missing an increment by one, which leads to the last query missing one
> This problem is resolved by adding a sentinel node.
> 
> Patch 2: In this scenario, the fsmap query for realtime deivce may display
> extra intervals. This is due to an extra increase in "end_rtb". The issue
> is resolved by adjusting the relevant calculations. And this patch depends
> on the previous patch that introduced "info->end_daddr".
> 
> [1] https://lore.kernel.org/all/20240819005320.304211-1-wozizhi@huawei.com/
> [2] https://lore.kernel.org/all/172437083728.56860.10056307551249098606.stgit@frogsfrogsfrogs/
> 
> Zizhi Wo (2):
>    xfs: Fix missing block calculations in xfs datadev fsmap
>    xfs: Fix incorrect parameter calculation in rt fsmap
> 
>   fs/xfs/libxfs/xfs_rtbitmap.c |  4 +---
>   fs/xfs/xfs_fsmap.c           | 39 +++++++++++++++++++++++++++++++-----
>   2 files changed, 35 insertions(+), 8 deletions(-)
>