linux-kernel - Re: [PATCH net-next v1] brcmfmac: Convert to use ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ed67ecw2.fsf@kernel.org>
Date: Thu, 29 Aug 2024 15:23:25 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Yuesong Li <liyuesong@...o.com>
Cc: kees@...nel.org,  johannes.berg@...el.com,  neal@...pa.dev,
  a@...repo.ru,  justinstitt@...gle.com,  marcan@...can.st,  j@...nau.net,
  wsa+renesas@...g-engineering.com,  brcm80211@...ts.linux.dev,
  brcm80211-dev-list.pdl@...adcom.com,  linux-kernel@...r.kernel.org,
  opensource.kernel@...o.com
Subject: Re: [PATCH net-next v1] brcmfmac: Convert to use ERR_CAST()

Yuesong Li <liyuesong@...o.com> writes:

> Use ERR_CAST() as it is designed for casting an error pointer to
> another type.
>
> This macro utilizes the __force and __must_check modifiers, which instruct
> the compiler to verify for errors at the locations where it is employed.
>
> Signed-off-by: Yuesong Li <liyuesong@...o.com>
> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +-
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Several problems:

* wireless patches go to wireless-next, not net-next

* "wifi:" missing from title

* you forgot to cc linux-wireless

Please fix these and submit v2. And please read the wiki link below.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches