[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <df7418a8-1626-4207-b23e-7f0dc3d83164@lunn.ch>
Date: Thu, 29 Aug 2024 14:38:58 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
woojung.huh@...rochip.com, f.fainelli@...il.com, olteanv@...il.com,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, linus.walleij@...aro.org, alsi@...g-olufsen.dk,
justin.chen@...adcom.com, sebastian.hesselbarth@...il.com,
alexandre.torgue@...s.st.com, joabreu@...opsys.com,
mcoquelin.stm32@...il.com, wens@...e.org, jernej.skrabec@...il.com,
samuel@...lland.org, hkallweit1@...il.com, linux@...linux.org.uk,
ansuelsmth@...il.com, UNGLinuxDriver@...rochip.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
bcm-kernel-feedback-list@...adcom.com,
linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
linux-stm32@...md-mailman.stormreply.com, krzk@...nel.org,
jic23@...nel.org
Subject: Re: [PATCH net-next v2 08/13] net: mdio: mux-mmioreg: Simplified
with dev_err_probe()
> >> + if ((u32)reg & ~s->mask)
> >> + return dev_err_probe(&pdev->dev, -ENODEV,
> >> + "mdio-mux child node %pOF has a 'reg' value with unmasked bits\n",
> > I'd align these super long ones as.
> > "mdio-mux child node %pOF has a 'reg' value with unmasked bits\n",
> > It is ugly but then so are > 100 char lines.
>
> It seems that this kind string > 100 char is fine for patch check script.
Strings like this can ignore the 80 char limit because developers are
going to grep for it when it shows up in their kernel log. If it gets
broken in odd places, grep will not find it.
I would also say the indentation is correct as is, level with &pdev.
Andrew
Powered by blists - more mailing lists