linux-kernel - Re: [PATCH v1 1/1] pinctrl: renesas: rzg2l: Replace of_node_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdX38O+TOhaK4_C5kh+11VwQTdnnSU=nhkSzdeJT=aMnxg@mail.gmail.com>
Date: Thu, 29 Aug 2024 14:51:02 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: linux-renesas-soc@...r.kernel.org, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Linus Walleij <linus.walleij@...aro.org>, 
	"Lad, Prabhakar" <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v1 1/1] pinctrl: renesas: rzg2l: Replace
 of_node_to_fwnode() with more suitable API

Hi Andy,

On Fri, Aug 23, 2024 at 3:17 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Fri, Aug 23, 2024 at 10:23 AM Geert Uytterhoeven
> <geert@...ux-m68k.org> wrote:
> > On Fri, Aug 23, 2024 at 1:01 AM Andy Shevchenko
> > <andy.shevchenko@...il.com> wrote:
> > > of_node_to_fwnode() is a IRQ domain specific implementation of
> > > of_fwnode_handle(). Replace the former with more suitable API.
>
> ...
>
> > > -       girq->fwnode = of_node_to_fwnode(np);
> > > +       girq->fwnode = dev_fwnode(pctrl->dev);
> >
> > While this looks correct, the new call goes through many more hoops, and
> > is not a simple inline function.

[...]

> P.S. Also note, it's _the only_ pin control driver that uses that API.

Thanks for the explanation!

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
i.e. will queue in renesas-pinctrl for v6.12.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds