linux-kernel - Re: [PATCH] hwmon: Add support for the INA260 chip to the INA219 and compatibles driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80ad5b6b-36b5-4d16-8bdb-93b94401a8a8@roeck-us.net>
Date: Thu, 29 Aug 2024 19:40:29 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Loic Guegan <loic.guegan@...lbox.org>
Cc: Jean Delvare <jdelvare@...e.com>, linux-kernel@...r.kernel.org,
	linux-hwmon@...r.kernel.org
Subject: Re: [PATCH] hwmon: Add support for the INA260 chip to the INA219 and
 compatibles driver

Hi,

On Sun, Aug 20, 2023 at 02:47:25PM +0200, Loic Guegan wrote:
> This patch allows to retrieve current, bus voltage and power
> measurements from the INA260 using its default configuration.
> 
> As the INA260 provides integrated shunt, the "ishunt" configuration
> parameter is introduced. As such, proper attributes can be attached
> with hwmon and shunt calibration related routnies can be ignored. In
> addition, the actual INA2XX current register address differ from the
> INA260 as it does not provide a shunt register. Thus, a specific
> register address INA2XX_CURRENT_ISHUNT for chips with integrated
> shunts is proposed.
> 
> Signed-off-by: Loic Guegan <loic.guegan@...lbox.org>

This patch will no longer apply after the series at
https://lore.kernel.org/linux-hwmon/20240830010554.1462861-1-linux@roeck-us.net/T/#t
is accepted and applied. It is also less than perfect since it does not 
support current limits. Adjusting the driver to support ina260 should be
much more straightforward after the above patches are applied. I'll send a
follow-up series of patches after I was able to test it with a real chip
(I am currently waiting for an evaluation board to arrive).

In case anyone is curious, the (untested) patches necessary to support
INA260 are available in the hwmon-staging and testing branches of
git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git

Guenter