linux-kernel - Re: [PATCH net-next v2] net: stmmac: drop the ethtool begin() callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8de6d7b7-686b-4eac-97da-6c7c9c590721@intel.com>
Date: Fri, 30 Aug 2024 15:35:00 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Andrew Halaney <ahalaney@...hat.com>
CC: Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu
	<joabreu@...opsys.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, "Abhishek
 Chauhan" <quic_abchauha@...cinc.com>, Sagar Cheluvegowda
	<quic_scheluve@...cinc.com>, Dmitry Dolenko <d.dolenko@...rotek.ru>,
	<netdev@...r.kernel.org>, <linux-stm32@...md-mailman.stormreply.com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2] net: stmmac: drop the ethtool begin()
 callback

From: Andrew Halaney <ahalaney@...hat.com>
Date: Thu, 29 Aug 2024 15:48:44 -0500

> This callback doesn't seem to serve much purpose, and prevents things
> like:
> 
>     - systemd.link files from disabling autonegotiation
>     - carrier detection in NetworkManager
>     - any ethtool setting
> 
> prior to userspace bringing the link up.
> 
> The only fear I can think of is accessing unclocked resources due to
> pm_runtime, but ethtool ioctls handle that as of commit
> f32a21376573 ("ethtool: runtime-resume netdev parent before ethtool ioctl ops")
> 
> Reviewed-by: Dmitry Dolenko <d.dolenko@...rotek.ru>
> Tested-by: Dmitry Dolenko <d.dolenko@...rotek.ru>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>

> Signed-off-by: Andrew Halaney <ahalaney@...hat.com>
Thanks,
Olek