linux-kernel - Re: [PATCH v1] kernel:time:hrtimer: Use helper function hrtimer_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e891a5cf-613d-4d7e-b146-798f60777a63@vivo.com>
Date: Fri, 30 Aug 2024 10:53:18 +0800
From: Yuesong Li <liyuesong@...o.com>
To: Thomas Gleixner <tglx@...utronix.de>, anna-maria@...utronix.de,
 frederic@...nel.org
Cc: linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] kernel:time:hrtimer: Use helper function
 hrtimer_is_queued()


On 2024/8/29 23:17, Thomas Gleixner wrote:
> On Wed, Aug 21 2024 at 17:46, Yuesong Li wrote:
>
> Please add a proper subsystem prefix to the subject.
>                                                                                                                                                                                                                                                                                                                                git log --oneline $FILE
> gives you a decent hint
I will send a v2 if you agree with my reason.
>> The helper function hrtimer_is_queued() checks whether the timer is
>> on one of the queues. Replace the raw check.
> Why? What's the benefit of this change?
Compare to raw check ,I think this makes the text more readable.
>
> Thanks,
>
>          tglx

Best Regards,

Yuesong