linux-kernel - Re: [PATCH] drm/imagination: Use pvr_vm_context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6cdb2df38ca349b5a10cc6583701876255e5f995.camel@imgtec.com>
Date: Fri, 30 Aug 2024 13:59:11 +0000
From: Frank Binns <Frank.Binns@...tec.com>
To: "tzimmermann@...e.de" <tzimmermann@...e.de>,
        Matt Coster
	<Matt.Coster@...tec.com>,
        "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>,
        "airlied@...il.com" <airlied@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "mripard@...nel.org"
	<mripard@...nel.org>
Subject: Re: [PATCH] drm/imagination: Use pvr_vm_context_get()

On Wed, 2024-08-28 at 13:09 +0000, Matt Coster wrote:
> I missed this open-coded kref_get() while trying to debug a refcount
> bug, so let's use the helper function here to avoid that waste of time
> again in the future.
> 

Reviewed-by: Frank Binns <frank.binns@...tec.com>

> Signed-off-by: Matt Coster <matt.coster@...tec.com>
> Fixes: ff5f643de0bf ("drm/imagination: Add GEM and VM related code")
> ---
>   drivers/gpu/drm/imagination/pvr_vm.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/imagination/pvr_vm.c 
> b/drivers/gpu/drm/imagination/pvr_vm.c
> index e59517ba039e..ffd466509d0b 100644
> --- a/drivers/gpu/drm/imagination/pvr_vm.c
> +++ b/drivers/gpu/drm/imagination/pvr_vm.c
> @@ -636,9 +636,7 @@ pvr_vm_context_lookup(struct pvr_file *pvr_file, u32 
> handle)
>    	xa_lock(&pvr_file->vm_ctx_handles);
>   	vm_ctx = xa_load(&pvr_file->vm_ctx_handles, handle);
> -	if (vm_ctx)
> -		kref_get(&vm_ctx->ref_count);
> -
> +	pvr_vm_context_get(vm_ctx);
>   	xa_unlock(&pvr_file->vm_ctx_handles);
>    	return vm_ctx;
> -- 
> 2.46.0
> 
>