linux-kernel - Re: [PATCH 3/5] pinctrl: mvebu: Use devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2ec65238-2c91-4c87-bf77-de2c6f5ac2c7@lunn.ch>
Date: Fri, 30 Aug 2024 16:04:39 +0200
From: Andrew Lunn <andrew@...n.ch>
To: 王建政 <wangjianzheng@...o.com>
Cc: Gregory Clement <gregory.clement@...tlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	"moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,..." <linux-arm-kernel@...ts.infradead.org>,
	"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	"opensource.kernel" <opensource.kernel@...o.com>
Subject: Re: [PATCH 3/5] pinctrl: mvebu: Use devm_clk_get_enabled() helpers

> Actually, I add "goto err_probe" in patch2/5 for fix the clock disable error. Based on that,
> I delete them in patch3/5. Because I want to use devm_clk_get_enabled() instead of original
>  devm_clk_get(), and need to remove the disable clock operation. 
> 
> It seems that it is unable to reverse the order of thes two patches. How about combining 
> These two patches into one? 

You should not add code and then delete it. How you achieve that is up
to you.

	Andrew