[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240830-retry-ranger-fdd01812a120@spud>
Date: Fri, 30 Aug 2024 15:16:26 +0100
From: Conor Dooley <conor@...nel.org>
To: Dharma.B@...rochip.com
Cc: ulf.hansson@...aro.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, Nicolas.Ferre@...rochip.com,
alexandre.belloni@...tlin.com, claudiu.beznea@...on.dev,
Aubin.Constans@...rochip.com, linux-mmc@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: mmc: sdhci-atmel: Convert to json
schema
On Fri, Aug 30, 2024 at 02:12:48PM +0000, Dharma.B@...rochip.com wrote:
> Hi Conor,
>
> On 30/08/24 7:18 pm, Conor Dooley wrote:
> > On Fri, Aug 30, 2024 at 01:49:42PM +0530, Dharma Balasubiramani wrote:
> >> Convert sdhci-atmel documentation to yaml format. The new file will inherit
> >> from sdhci-common.yaml.
> >>
> >> Note: Add microchip,sama7g5-sdhci to compatible list as we already use it
> >> in the DT.
> >>
> >> Signed-off-by: Dharma Balasubiramani<dharma.b@...rochip.com>
> >> ---
> >> .../bindings/mmc/atmel,sama5d2-sdhci.yaml | 98 ++++++++++++++++++++++
> >> .../devicetree/bindings/mmc/sdhci-atmel.txt | 35 --------
> >> 2 files changed, 98 insertions(+), 35 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
> >> new file mode 100644
> >> index 000000000000..91d18b2545e1
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
> >> @@ -0,0 +1,98 @@
> >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id:http://devicetree.org/schemas/mmc/atmel,sama5d2-sdhci.yaml#
> >> +$schema:http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Atmel SDHCI controller
> >> +
> >> +maintainers:
> >> + - Aubin Constans<aubin.constans@...rochip.com>
> >> + - Nicolas Ferre<nicolas.ferre@...rochip.com>
> >> +
> >> +description:
> >> + Bindings for the SDHCI controller found in Atmel/Microchip SoCs.
> >> +
> >> +properties:
> >> + compatible:
> >> + oneOf:
> >> + - enum:
> >> + - atmel,sama5d2-sdhci
> >> + - atmel,sama5d3-sdhci
> >> + - atmel,sama5d4-sdhci
> >> + - microchip,sam9x60-sdhci
> >> + - items:
> >> + - enum:
> >> + - microchip,sama7g5-sdhci
> >> + - const: microchip,sam9x60-sdhci
> >> +
> >> + reg:
> >> + maxItems: 1
> >> +
> >> + interrupts:
> >> + maxItems: 1
> >> +
> >> + clocks:
> >> + minItems: 2
> >> + maxItems: 3
> >> + description: |
> >> + The sama5d2 family includes three clocks: `hclock`, `multclk`, and `baseclk`.
> >> + For other families, including sam9x60 and sam9x7, only `hclock` and `multclk` are used.
> > This should instead be an items list, rather than a text based
> > description.
> Sure, I will update it like this below
>
> clocks:
> items:
> - description: hclock
> - description: multclk
> - description: baseclk
> minItems: 2
> maxItems: 3
This shouldn't pass dt_binding_check, because the max in this snippet is
redundant due to it matching the size of the items list.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists