[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZtE5Z/gDR1WixG9S@MiWiFi-R3L-srv>
Date: Fri, 30 Aug 2024 11:15:51 +0800
From: Baoquan He <bhe@...hat.com>
To: Dave Vasilevsky <dave@...ilevsky.ca>
Cc: glaubitz@...sik.fu-berlin.de, linuxppc-dev@...ts.ozlabs.org,
linux-sh@...r.kernel.org, mpe@...erman.id.au,
kexec@...ts.infradead.org, linux-kernel@...r.kernel.org,
Reimar Döffinger <Reimar.Doeffinger@....de>
Subject: Re: [PATCH] crash: Default to CRASH_DUMP=n when support for it is
unlikely
Hi Dave,
On 08/23/24 at 08:51am, Dave Vasilevsky wrote:
......snip..
> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> index 1aa3c4a0c5b2..b04cfa23378c 100644
> --- a/arch/sh/Kconfig
> +++ b/arch/sh/Kconfig
> @@ -549,6 +549,9 @@ config ARCH_SUPPORTS_KEXEC
> config ARCH_SUPPORTS_CRASH_DUMP
> def_bool BROKEN_ON_SMP
>
> +config ARCH_DEFAULT_CRASH_DUMP
> + def_bool n
If we don't add ARCH_DEFAULT_CRASH_DUMP at all in sh arch, the
CRASH_DUMP will be off by default according to the below new definition
of CRASH_DUMP?
Thanks
Baoquan
> +
> config ARCH_SUPPORTS_KEXEC_JUMP
> def_bool y
>
......
> diff --git a/kernel/Kconfig.kexec b/kernel/Kconfig.kexec
> index 6c34e63c88ff..4d111f871951 100644
> --- a/kernel/Kconfig.kexec
> +++ b/kernel/Kconfig.kexec
> @@ -97,7 +97,7 @@ config KEXEC_JUMP
>
> config CRASH_DUMP
> bool "kernel crash dumps"
> - default y
> + default ARCH_DEFAULT_CRASH_DUMP
> depends on ARCH_SUPPORTS_CRASH_DUMP
> depends on KEXEC_CORE
> select VMCORE_INFO
> --
> 2.34.1
>
Powered by blists - more mailing lists