lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <62C8CA0E-6013-487D-A3F0-C6069B854BCB@oracle.com>
Date: Fri, 30 Aug 2024 14:48:19 +0000
From: Chuck Lever III <chuck.lever@...cle.com>
To: Jeff Layton <jlayton@...nel.org>
CC: Neil Brown <neilb@...e.de>, Olga Kornievskaia <kolga@...app.com>,
        Dai Ngo
	<dai.ngo@...cle.com>, Tom Talpey <tom@...pey.com>,
        Trond Myklebust
	<trondmy@...nel.org>,
        Anna Schumaker <anna@...nel.org>,
        Olga Kornievskaia
	<okorniev@...hat.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Christian Brauner
	<brauner@...nel.org>, Jan Kara <jack@...e.cz>,
        Jonathan Corbet
	<corbet@....net>, Tom Haynes <loghyr@...il.com>,
        Linux Kernel Mailing List
	<linux-kernel@...r.kernel.org>,
        Linux NFS Mailing List
	<linux-nfs@...r.kernel.org>,
        Linux FS Devel <linux-fsdevel@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH v3 08/13] nfs_common: make nfs4.h include generated
 nfs4_1.h



> On Aug 29, 2024, at 2:26 PM, Jeff Layton <jlayton@...nel.org> wrote:
> 
> On Thu, 2024-08-29 at 11:13 -0400, Chuck Lever wrote:
>> On Thu, Aug 29, 2024 at 09:26:46AM -0400, Jeff Layton wrote:
>>> 
>>> index 6833d0ad35a8..00e803781c87 100644
>>> --- a/fs/nfsd/nfs4xdr_gen.c
>>> +++ b/fs/nfsd/nfs4xdr_gen.c
>>> @@ -2,7 +2,7 @@
>>> // Generated by xdrgen. Manual edits will be lost.
>>> // XDR specification modification time: Wed Aug 28 09:57:28 2024
>>> 
>>> -#include "nfs4xdr_gen.h"
>>> +#include <linux/sunrpc/xdrgen/nfs4_1.h>
>> 
>> Please don't hand-edit these files. That makes it impossible to just
>> run the xdrgen tool and get a new version, which is the real goal.
>> 
>> If you need different generated content, change the tool to generate
>> what you need (or feel free to ask me to get out my whittling
>> knife).
> 
> No problem. This part is a Q&D hack job to get everything working with
> minimal changes. Changing the tool to generate the right thing would be
> a better long-term solution (once we settle on where these files will
> go, etc.)

OK, that makes sense.

Going forward I will watch for such Q&D edits in the generated
files and try to address those in xdrgen. I would like to avoid
actually /committing/ such edits, though, because IMO we are
pretty active here right now and can get the "long term" fix
done quickly.

Meanwhile, I've updated the xdrgen patches in nfsd-next to
address many (or maybe all) of your requests from yesterday.

The header file is now split between

  include/linux/sunrpc/xdrgen/nfs4.h (protocol definitions)

and

  fs/nfsd/nfs4xdr_gen.h (function declarations)


--
Chuck Lever


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ