linux-kernel - Re: [PATCH net-next v2 05/12] net: vxlan: make vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06acad9a-2998-4c70-b186-c37739473346@intel.com>
Date: Fri, 30 Aug 2024 16:49:41 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Menglong Dong <menglong8.dong@...il.com>
CC: <idosch@...dia.com>, <kuba@...nel.org>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <pabeni@...hat.com>, <dsahern@...nel.org>,
	<dongml2@...natelecom.cn>, <amcohen@...dia.com>, <gnault@...hat.com>,
	<bpoirier@...dia.com>, <b.galvani@...il.com>, <razor@...ckwall.org>,
	<petrm@...dia.com>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 05/12] net: vxlan: make vxlan_remcsum() return
 drop reasons

From: Menglong Dong <menglong8.dong@...il.com>
Date: Fri, 30 Aug 2024 09:59:54 +0800

> Make vxlan_remcsum() support skb drop reasons by changing the return
> value type of it from bool to enum skb_drop_reason.
> 
> The only drop reason in vxlan_remcsum() comes from pskb_may_pull_reason(),
> so we just return it.
> 
> Signed-off-by: Menglong Dong <dongml2@...natelecom.cn>
> ---
>  drivers/net/vxlan/vxlan_core.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
> index fcd224a1d0c0..76b217d166ef 100644
> --- a/drivers/net/vxlan/vxlan_core.c
> +++ b/drivers/net/vxlan/vxlan_core.c
> @@ -1551,9 +1551,11 @@ static void vxlan_sock_release(struct vxlan_dev *vxlan)
>  #endif
>  }
>  
> -static bool vxlan_remcsum(struct vxlanhdr *unparsed,
> -			  struct sk_buff *skb, u32 vxflags)
> +static enum skb_drop_reason vxlan_remcsum(struct vxlanhdr *unparsed,
> +					  struct sk_buff *skb,
> +					  u32 vxflags)
>  {
> +	enum skb_drop_reason reason;
>  	size_t start, offset;
>  
>  	if (!(unparsed->vx_flags & VXLAN_HF_RCO) || skb->remcsum_offload)
> @@ -1562,15 +1564,16 @@ static bool vxlan_remcsum(struct vxlanhdr *unparsed,
>  	start = vxlan_rco_start(unparsed->vx_vni);
>  	offset = start + vxlan_rco_offset(unparsed->vx_vni);
>  
> -	if (!pskb_may_pull(skb, offset + sizeof(u16)))
> -		return false;
> +	reason = pskb_may_pull_reason(skb, offset + sizeof(u16));
> +	if (reason)
> +		return reason;
>  
>  	skb_remcsum_process(skb, (void *)(vxlan_hdr(skb) + 1), start, offset,
>  			    !!(vxflags & VXLAN_F_REMCSUM_NOPARTIAL));
>  out:
>  	unparsed->vx_flags &= ~VXLAN_HF_RCO;
>  	unparsed->vx_vni &= VXLAN_VNI_MASK;
> -	return true;

Also an empty newline before return.

> +	return SKB_NOT_DROPPED_YET;
>  }
>  
>  static void vxlan_parse_gbp_hdr(struct vxlanhdr *unparsed,

Thanks,
Olek