linux-kernel - Re: [PATCH v2] aarch64: vdso: Wire up getrandom() vDSO implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0642c77-34be-4082-be92-1c32c912b9ce@sirena.org.uk>
Date: Fri, 30 Aug 2024 16:05:24 +0100
From: Mark Brown <broonie@...nel.org>
To: "Jason A. Donenfeld" <Jason@...c4.com>
Cc: Will Deacon <will@...nel.org>,
	Adhemerval Zanella <adhemerval.zanella@...aro.org>,
	Theodore Ts'o <tytso@....edu>, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-arch@...r.kernel.org,
	Catalin Marinas <catalin.marinas@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Eric Biggers <ebiggers@...nel.org>,
	Christophe Leroy <christophe.leroy@...roup.eu>, ardb@...nel.org
Subject: Re: [PATCH v2] aarch64: vdso: Wire up getrandom() vDSO implementation

On Fri, Aug 30, 2024 at 02:04:39PM +0200, Jason A. Donenfeld wrote:
> > > +SYM_FUNC_START(__arch_chacha20_blocks_nostack)

> > Is there any way we can reuse the existing code in
> > crypto/chacha-neon-core.S for this? It looks to my untrained eye like
> > this is an arbitrarily different implementation to what we already have.

> Nope, it is indeed different, and not arbitrarily so. This patch is
> mirroring exactly what we did on x86.

It's probably worth some comments or something explaining what's going
on with that (the commit log for the x86 patch mentions that it's that
the vDSO needs a version that doesn't write to the stack).

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)