[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240830175504.746fb2ec@xps-13>
Date: Fri, 30 Aug 2024 17:55:04 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Cheng Ming Lin <linchengming884@...il.com>
Cc: vigneshr@...com, linux-mtd@...ts.infradead.org,
linux-kernel@...r.kernel.org, richard@....at, alvinzhou@...c.com.tw,
leoyu@...c.com.tw, Cheng Ming Lin <chengminglin@...c.com.tw>
Subject: Re: [PATCH v5 1/2] mtd: spinand: Add support for setting plane
select bits
Hi ChengMing,
linchengming884@...il.com wrote on Fri, 30 Aug 2024 18:03:09 +0800:
> From: Cheng Ming Lin <chengminglin@...c.com.tw>
>
> Add two flags for inserting the Plane Select bit into the column
> address during the write_to_cache and the read_from_cache operation.
>
> Add the SPINAND_HAS_PP_PLANE_SELECT_BIT flag for serial NAND flash
This flag has been renamed :)
> that require inserting the Plane Select bit into the column address
> during the write_to_cache operation.
>
> Add the SPINAND_HAS_READ_PLANE_SELECT_BIT flag for serial NAND flash
> that require inserting the Plane Select bit into the column address
> during the read_from_cache operation.
>
> Signed-off-by: Cheng Ming Lin <chengminglin@...c.com.tw>
> ---
> drivers/mtd/nand/spi/core.c | 6 ++++++
> include/linux/mtd/spinand.h | 2 ++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
> index e0b6715e5dfe..e7b592cdbb4c 100644
> --- a/drivers/mtd/nand/spi/core.c
> +++ b/drivers/mtd/nand/spi/core.c
> @@ -386,6 +386,9 @@ static int spinand_read_from_cache_op(struct spinand_device *spinand,
> else
> rdesc = spinand->dirmaps[req->pos.plane].rdesc_ecc;
>
> + if (spinand->flags & SPINAND_HAS_READ_PLANE_SELECT_BIT)
> + column |= req->pos.plane << fls(nanddev_page_size(nand));
Isn't there any better way to know what the bit position is?
Thanks,
Miquèl
Powered by blists - more mailing lists