linux-kernel - Re: [PATCH v3] arm: dts: st: stm32mp151a-prtt1l: Fix QSPI configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60f38cec-1942-41a1-9d5e-0eeaaeed0667@foss.st.com>
Date: Fri, 30 Aug 2024 18:03:30 +0200
From: Alexandre TORGUE <alexandre.torgue@...s.st.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>,
        Maxime Coquelin
	<mcoquelin.stm32@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>
CC: Ahmad Fatoum <a.fatoum@...gutronix.de>, <kernel@...gutronix.de>,
        <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH v3] arm: dts: st: stm32mp151a-prtt1l: Fix QSPI
 configuration

Hi Oleksij,

On 8/12/24 12:41, Oleksij Rempel wrote:
> Rename 'pins1' to 'pins' in the qspi_bk1_pins_a node to correct the
> subnode name. The incorrect name caused the configuration to be
> applied to the wrong subnode, resulting in QSPI not working properly.
> 
> Some additional changes was made:
> - To avoid this kind of regression, all references to pin configuration
>    nodes are now referenced directly using the format &{label/subnode}.
> - /delete-property/ bias-disable; was added everywhere where bias-pull-up
>    is used
> - redundant properties like driver-push-pull are removed
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> Reviewed-by: Ahmad Fatoum <a.fatoum@...gutronix.de>
> ---
> changes v3:
> - extend comment message
> ---
>   arch/arm/boot/dts/st/stm32mp151a-prtt1a.dts  |  12 +-
>   arch/arm/boot/dts/st/stm32mp151a-prtt1c.dts  | 108 +++++++---------
>   arch/arm/boot/dts/st/stm32mp151a-prtt1l.dtsi | 126 +++++++++----------
>   arch/arm/boot/dts/st/stm32mp151a-prtt1s.dts  |  16 +--
>   4 files changed, 116 insertions(+), 146 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/st/stm32mp151a-prtt1a.dts b/arch/arm/boot/dts/st/stm32mp151a-prtt1a.dts
> index 75874eafde11e..8e1dd84e0c0a4 100644
> --- a/arch/arm/boot/dts/st/stm32mp151a-prtt1a.dts
> +++ b/arch/arm/boot/dts/st/stm32mp151a-prtt1a.dts
> @@ -28,16 +28,12 @@ phy0: ethernet-phy@0 {
>   	};
>   };
>
...

Applied on stm32-next.

Thanks
Alex