linux-kernel - Re: [PATCH v13 04/10] mm: split a folio in minimum folio order chunks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtH9dA7Xe7K5aSwg@bombadil.infradead.org>
Date: Fri, 30 Aug 2024 10:12:20 -0700
From: Luis Chamberlain <mcgrof@...nel.org>
To: Pankaj Raghav <kernel@...kajraghav.com>
Cc: Zi Yan <ziy@...dia.com>, Matthew Wilcox <willy@...radead.org>,
	Sven Schnelle <svens@...ux.ibm.com>, brauner@...nel.org,
	akpm@...ux-foundation.org, chandan.babu@...cle.com,
	linux-fsdevel@...r.kernel.org, djwong@...nel.org, hare@...e.de,
	gost.dev@...sung.com, linux-xfs@...r.kernel.org, hch@....de,
	david@...morbit.com, yang@...amperecomputing.com,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	john.g.garry@...cle.com, cl@...amperecomputing.com,
	p.raghav@...sung.com, ryan.roberts@....com,
	David Howells <dhowells@...hat.com>, linux-s390@...r.kernel.org
Subject: Re: [PATCH v13 04/10] mm: split a folio in minimum folio order chunks

On Fri, Aug 30, 2024 at 04:59:57PM +0200, Pankaj Raghav wrote:
> It feels a bit weird to pass both folio and the page in `split_page_folio_to_list()`.

Agreed..

> How about we extract the code that returns the min order so that we don't repeat.
> Something like this:

Of all solutions I like this the most, Zi, do you have any preference?

  Luis