lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <403cc76f-7ba4-412b-9784-af6a6e14cf4a@kernel.org>
Date: Fri, 30 Aug 2024 19:53:38 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Chen Yufan <chenyufan@...o.com>, Emilio López
 <emilio@...pez.com.ar>, Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
 Jernej Skrabec <jernej.skrabec@...il.com>,
 Samuel Holland <samuel@...lland.org>, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH v1] clk: sunxi: sun9i-mmc: Use dev_err_probe() to simplfy
 code

On 30/08/2024 09:27, Chen Yufan wrote:
> Use dev_err_probe() can make code a bit simpler.
> 
> Signed-off-by: Chen Yufan <chenyufan@...o.com>
> ---
>  drivers/clk/sunxi/clk-sun9i-mmc.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/sunxi/clk-sun9i-mmc.c b/drivers/clk/sunxi/clk-sun9i-mmc.c
> index 91074017c04f..e6b62e421936 100644
> --- a/drivers/clk/sunxi/clk-sun9i-mmc.c
> +++ b/drivers/clk/sunxi/clk-sun9i-mmc.c
> @@ -134,10 +134,8 @@ static int sun9i_a80_mmc_config_clk_probe(struct platform_device *pdev)
>  	}
>  
>  	ret = reset_control_deassert(data->reset);
> -	if (ret) {
> -		dev_err(&pdev->dev, "Reset deassert err %d\n", ret);
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(&pdev->dev, ret, "Reset deassert err %d\n");

This is ridiculous.

You change something which cannot defer, while leaving other places
which actually can defer and could benefit.

Stop spamming with such low quality patches.

Best regards,
Krzysztof


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ