linux-kernel - Re: [PATCH] cpufreq: ti-cpufreq: Introduce quirks to handle syscon fails appropriately

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7hjzfxx56r.fsf@baylibre.com>
Date: Fri, 30 Aug 2024 10:59:24 -0700
From: Kevin Hilman <khilman@...nel.org>
To: Nishanth Menon <nm@...com>, "H. Nikolaus Schaller" <hns@...delico.com>,
 Viresh Kumar <viresh.kumar@...aro.org>, "Rafael J. Wysocki"
 <rafael@...nel.org>
Cc: Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org, linux-omap@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, bb@...com, d-gole@...com, Nishanth
 Menon <nm@...com>
Subject: Re: [PATCH] cpufreq: ti-cpufreq: Introduce quirks to handle syscon
 fails appropriately

Nishanth Menon <nm@...com> writes:

> Commit b4bc9f9e27ed ("cpufreq: ti-cpufreq: add support for omap34xx
> and omap36xx") introduced special handling for OMAP3 class devices
> where syscon node may not be present. However, this also creates a bug
> where the syscon node is present, however the offset used to read
> is beyond the syscon defined range.
>
> Fix this by providing a quirk option that is populated when such
> special handling is required. This allows proper failure for all other
> platforms when the syscon node and efuse offsets are mismatched.
>
> Fixes: b4bc9f9e27ed ("cpufreq: ti-cpufreq: add support for omap34xx and omap36xx")
> Signed-off-by: Nishanth Menon <nm@...com>
> ---
>
> NOTE: this combined with https://lore.kernel.org/r/20240828121008.3066002-1-nm@ti.com
> has created a bunch of un-intended bugs on other TI SoCs such
> as seen in https://lore.kernel.org/all/20240826-opp-v3-1-0934f8309e13@ti.com/
> https://lore.kernel.org/all/20240827131342.6wrielete3yeoinl@bryanbrattlof.com/
> etc.

Reviewed-by: Kevin Hilman <khilman@...libre.com>