[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <b7b1fb8f-8bfb-424a-abd2-01ba5a68c804@kernel.org>
Date: Fri, 30 Aug 2024 20:15:22 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: arnd@...db.de, gregkh@...uxfoundation.org
Cc: linux-kernel@...r.kernel.org, opensource.kernel@...o.com,
haver@...ux.ibm.com, Shen Lichuan <shenlichuan@...o.com>
Subject: Re: [PATCH v1] misc: genwqe: Simplify with dev_err_probe()
On 30/08/2024 10:38, Shen Lichuan wrote:
> Use dev_err_probe() to simplify the error path and unify a message
> template.
>
> Using this helper is totally fine even if err is known to never
> be -EPROBE_DEFER.
>
> The benefit compared to a normal dev_err() is the standardized format
> of the error code, it being emitted symbolically and the fact that
> the error code is returned which allows more compact error paths.
>
> Signed-off-by: Shen Lichuan <shenlichuan@...o.com>
> ---
> drivers/misc/genwqe/card_base.c | 21 +++++++++------------
> 1 file changed, 9 insertions(+), 12 deletions(-)
>
Since ~2 weeks there is tremendous amount of trivial patches coming from
vivo.com. I identified at least 6 buggy, where the contributor did not
understand the code. Not sure about intention, but I advise extra
carefulness when dealing with these "trivial" improvements (because we
tend to apply things which look trivial).
Best regards,
Krzysztof
Powered by blists - more mailing lists