linux-kernel - Re: [PATCH v2 1/1] i2c: designware: Consolidate PM ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtIRMLwJhKHGVwNv@smile.fi.intel.com>
Date: Fri, 30 Aug 2024 21:36:32 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: "Goswami, Sanket" <Sanket.Goswami@....com>
Cc: Andi Shyti <andi.shyti@...nel.org>, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Jan Dabros <jsd@...ihalf.com>, Narasimhan.V@....com,
	Borislav Petkov <bp@...en8.de>, Kim Phillips <kim.phillips@....com>,
	Shyam-sundar.S-k@....com
Subject: Re: [PATCH v2 1/1] i2c: designware: Consolidate PM ops

On Thu, Aug 29, 2024 at 08:25:27PM +0530, Goswami, Sanket wrote:
> Adding Shyam (as he asked me to check this change on AMD systems)
> On 8/27/2024 8:30 PM, Andy Shevchenko wrote:
> > We have the same (*) PM ops in the PCI and plaform drivers.
> > Instead, consolidate that PM ops under exported variable and
> > deduplicate them.
> > 
> > *)
> > With the subtle ACPI and P-Unit behaviour differences in PCI case.
> > But this is not a problem as for ACPI we need to take care of the
> > P-Unit semaphore anyway and calling PM ops for PCI makes sense as
> > it might provide specific operation regions in ACPI (however there
> > are no known devices on market that are using it with PCI enabled I2C).
> > Note, the clocks are not in use in the PCI case.
> > 
> > Reviewed-by: Andi Shyti <andi.shyti@...nel.org>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> Tested-by: Sanket Goswami <Sanket.Goswami@....com>

Thank you! Andi, can you apply this now?

-- 
With Best Regards,
Andy Shevchenko