linux-kernel - Re: [PATCH 2/3] Staging: rtl8192e: Rename variable bHwError

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6885753f-d663-4e00-9007-60f8d659804f@gmail.com>
Date: Fri, 30 Aug 2024 21:11:55 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Tree Davies <tdavies@...kphysics.net>, gregkh@...uxfoundation.org,
 anjan@...i.ca
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] Staging: rtl8192e: Rename variable bHwError

On 8/30/24 04:05, Tree Davies wrote:
> Rename variable bHwError to hw_error
> to fix checkpatch warning Avoid CamelCase.
> 
> Signed-off-by: Tree Davies <tdavies@...kphysics.net>
> ---
>   drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8 ++++----
>   drivers/staging/rtl8192e/rtllib.h              | 2 +-
>   2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index 519cad9e1106..15fda2d87da9 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -1506,7 +1506,7 @@ static void _rtl92e_translate_rx_signal_stats(struct net_device *dev,
>   				  (fc & IEEE80211_FCTL_TODS) ? hdr->addr1 :
>   				  (fc & IEEE80211_FCTL_FROMDS) ? hdr->addr2 :
>   				  hdr->addr3) &&
> -		 (!pstats->bHwError) && (!pstats->bCRC) && (!pstats->bICV));
> +		 (!pstats->hw_error) && (!pstats->bCRC) && (!pstats->bICV));
>   	bpacket_toself = bpacket_match_bssid &&		/* check this */
>   			 ether_addr_equal(praddr, priv->rtllib->dev->dev_addr);
>   	if (ieee80211_is_beacon(hdr->frame_control))
> @@ -1630,13 +1630,13 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats,
>   
>   	stats->bICV = pdesc->ICV;
>   	stats->bCRC = pdesc->CRC32;
> -	stats->bHwError = pdesc->CRC32 | pdesc->ICV;
> +	stats->hw_error = pdesc->CRC32 | pdesc->ICV;
>   
>   	stats->Length = pdesc->Length;
>   	if (stats->Length < 24)
> -		stats->bHwError |= 1;
> +		stats->hw_error |= 1;
>   
> -	if (stats->bHwError)
> +	if (stats->hw_error)
>   		return false;
>   
>   	stats->RxDrvInfoSize = pdesc->RxDrvInfoSize;
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 82fef04e5784..76f53b797644 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -467,7 +467,7 @@ struct rtllib_rx_stats {
>   	u8  SignalQuality;
>   	s32 RecvSignalPower;
>   	u8  SignalStrength;
> -	u16 bHwError:1;
> +	u16 hw_error:1;
>   	u16 bCRC:1;
>   	u16 bICV:1;
>   	u16 decrypted:1;

Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com>