linux-kernel - Re: [PATCH v2] drivers: spi: Insert the missing pci_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a906ee9-7b28-45e4-be67-ab3b6c5f89b1@sirena.org.uk>
Date: Fri, 30 Aug 2024 20:57:47 +0100
From: Mark Brown <broonie@...nel.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Yang Ruibin <11162571@...o.com>, Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	linux-arm-kernel@...ts.infradead.org, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org, opensource.kernel@...o.com,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v2] drivers: spi: Insert the missing pci_dev_put()before
 return

On Fri, Aug 30, 2024 at 10:55:06AM +0200, Geert Uytterhoeven wrote:
> On Thu, Aug 29, 2024 at 5:35 AM Yang Ruibin <11162571@...o.com> wrote:

> > -       if (ret)
> > +       if (ret) {
> > +               pci_dev_put(dma_dev);

> dma_dev is still uninitialized at this point.

I'm a bit concerned that this isn't picked up by an allmodconfig with
the -Werror...  I'm currently using GCC 12 for that.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)