linux-kernel - Re: [PATCH] net: alacritech: Partially revert "net: alacritech: Switch to use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f8fbbe7-4a91-4a18-a277-06d144844c2a@lunn.ch>
Date: Fri, 30 Aug 2024 22:34:16 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Simon Horman <horms@...nel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Lino Sanfilippo <LinoSanfilippo@....de>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jacob Keller <jacob.e.keller@...el.com>,
	Yang Ruibin <11162571@...o.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: alacritech: Partially revert "net: alacritech:
 Switch to use dev_err_probe()"

On Fri, Aug 30, 2024 at 07:28:44PM +0100, Simon Horman wrote:
> On Fri, Aug 30, 2024 at 07:00:14PM +0200, Krzysztof Kozlowski wrote:
> > This reverts commit bf4d87f884fe8a4b6b61fe4d0e05f293d08df61c because it
> > introduced dev_err_probe() in non-probe path, which is not desired.
> > Calling it after successful probe, dev_err_probe() will set deferred
> > status on the device already probed. See also documentation of
> > dev_err_probe().
> 
> I agree that using dev_err_probe() outside of a probe path is
> inappropriate. And I agree that your patch addresses that problem
> in the context of changes made by the cited commit.

Maybe device_set_deferred_probe_reason() could call device_is_bound()
is check the device is not actually bound, and hence still in probe,
and do a dev_warn(). That should help catch these errors.

I assume the developers submitting these patches are also using a
bot. It would be good if the bot could be trained to follow the call
paths and ensure it only reports cases which are probe.

	Andrew