[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202408310524.JPBkb81E-lkp@intel.com>
Date: Sat, 31 Aug 2024 05:37:32 +0800
From: kernel test robot <lkp@...el.com>
To: Louis Chauvet <louis.chauvet@...tlin.com>,
Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>,
Melissa Wen <melissa.srw@...il.com>,
Maíra Canal <mairacanal@...eup.net>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
dri-devel@...ts.freedesktop.org, arthurgrillo@...eup.net,
linux-kernel@...r.kernel.org, jeremie.dautheribes@...tlin.com,
miquel.raynal@...tlin.com, thomas.petazzoni@...tlin.com,
seanpaul@...gle.com, nicolejadeyee@...gle.com,
Louis Chauvet <louis.chauvet@...tlin.com>
Subject: Re: [PATCH v2 5/6] drm/vkms: Switch to managed for CRTC
Hi Louis,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 071d583e01c88272f6ff216d4f867f8f35e94d7d]
url: https://github.com/intel-lab-lkp/linux/commits/Louis-Chauvet/drm-vkms-Switch-to-managed-for-connector/20240827-180427
base: 071d583e01c88272f6ff216d4f867f8f35e94d7d
patch link: https://lore.kernel.org/r/20240827-google-vkms-managed-v2-5-f41104553aeb%40bootlin.com
patch subject: [PATCH v2 5/6] drm/vkms: Switch to managed for CRTC
config: i386-buildonly-randconfig-004-20240831 (https://download.01.org/0day-ci/archive/20240831/202408310524.JPBkb81E-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240831/202408310524.JPBkb81E-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408310524.JPBkb81E-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/vkms/vkms_output.c:58:6: warning: variable 'cursor' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
58 | if (vkmsdev->config->cursor) {
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/vkms/vkms_output.c:65:10: note: uninitialized use occurs here
65 | cursor ? &cursor->base : NULL);
| ^~~~~~
drivers/gpu/drm/vkms/vkms_output.c:58:2: note: remove the 'if' if its condition is always true
58 | if (vkmsdev->config->cursor) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/vkms/vkms_output.c:32:37: note: initialize the variable 'cursor' to silence this warning
32 | struct vkms_plane *primary, *cursor, *overlay = NULL;
| ^
| = NULL
1 warning generated.
vim +58 drivers/gpu/drm/vkms/vkms_output.c
d16489307a52f0 Rodrigo Siqueira 2018-07-11 29
e9d85f731de06a Rodrigo Siqueira 2019-06-25 30 int vkms_output_init(struct vkms_device *vkmsdev, int index)
854502fa0a38dc Rodrigo Siqueira 2018-05-16 31 {
2abd7e59001123 Louis Chauvet 2024-08-27 32 struct vkms_plane *primary, *cursor, *overlay = NULL;
854502fa0a38dc Rodrigo Siqueira 2018-05-16 33 struct drm_device *dev = &vkmsdev->drm;
a12934d3402c04 Louis Chauvet 2024-08-27 34 struct drm_connector *connector;
e3b4c152118a04 Louis Chauvet 2024-08-27 35 struct drm_encoder *encoder;
2abd7e59001123 Louis Chauvet 2024-08-27 36 struct vkms_crtc *crtc;
df2d385cb4132e José Expósito 2022-01-07 37 unsigned int n;
2abd7e59001123 Louis Chauvet 2024-08-27 38 int ret;
854502fa0a38dc Rodrigo Siqueira 2018-05-16 39
2abd7e59001123 Louis Chauvet 2024-08-27 40 /*
2abd7e59001123 Louis Chauvet 2024-08-27 41 * Initialize used plane. One primary plane is required to perform the composition.
2abd7e59001123 Louis Chauvet 2024-08-27 42 *
2abd7e59001123 Louis Chauvet 2024-08-27 43 * The overlay and cursor planes are not mandatory, but can be used to perform complex
2abd7e59001123 Louis Chauvet 2024-08-27 44 * composition.
2abd7e59001123 Louis Chauvet 2024-08-27 45 */
e9d85f731de06a Rodrigo Siqueira 2019-06-25 46 primary = vkms_plane_init(vkmsdev, DRM_PLANE_TYPE_PRIMARY, index);
854502fa0a38dc Rodrigo Siqueira 2018-05-16 47 if (IS_ERR(primary))
854502fa0a38dc Rodrigo Siqueira 2018-05-16 48 return PTR_ERR(primary);
854502fa0a38dc Rodrigo Siqueira 2018-05-16 49
310e506c06e495 Melissa Wen 2021-04-24 50 if (vkmsdev->config->overlay) {
df2d385cb4132e José Expósito 2022-01-07 51 for (n = 0; n < NUM_OVERLAY_PLANES; n++) {
2abd7e59001123 Louis Chauvet 2024-08-27 52 overlay = vkms_plane_init(vkmsdev, DRM_PLANE_TYPE_OVERLAY, index);
2abd7e59001123 Louis Chauvet 2024-08-27 53 if (IS_ERR(overlay))
2abd7e59001123 Louis Chauvet 2024-08-27 54 return PTR_ERR(overlay);
310e506c06e495 Melissa Wen 2021-04-24 55 }
df2d385cb4132e José Expósito 2022-01-07 56 }
310e506c06e495 Melissa Wen 2021-04-24 57
2df7af93fdadb9 Sumera Priyadarsini 2021-01-12 @58 if (vkmsdev->config->cursor) {
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists