linux-kernel - Re: [PATCH -next 1/3] ata: pata_ftide010: Enable module autoloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a6e269c-255c-4cca-b389-e54c0e7e571a@kernel.org>
Date: Fri, 30 Aug 2024 13:51:15 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Liao Chen <liaochen4@...wei.com>, linux-ide@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: linus.walleij@...aro.org, s.shtylyov@....ru, cassel@...nel.org
Subject: Re: [PATCH -next 1/3] ata: pata_ftide010: Enable module autoloading

On 8/29/24 10:19 PM, Liao Chen wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based

s/could/can

Same comment for the other 2 patches. Other than that, looks good.
Feel free to add Sergey's review tag when sending v2. Thanks.

> on the alias from of_device_id table.
> 
> Signed-off-by: Liao Chen <liaochen4@...wei.com>
> ---
>  drivers/ata/pata_ftide010.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ata/pata_ftide010.c b/drivers/ata/pata_ftide010.c
> index 4d6ef90ccc77..73a9a5109238 100644
> --- a/drivers/ata/pata_ftide010.c
> +++ b/drivers/ata/pata_ftide010.c
> @@ -549,6 +549,7 @@ static const struct of_device_id pata_ftide010_of_match[] = {
>  	{ .compatible = "faraday,ftide010", },
>  	{ /* sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, pata_ftide010_of_match);
>  
>  static struct platform_driver pata_ftide010_driver = {
>  	.driver = {

-- 
Damien Le Moal
Western Digital Research