linux-kernel - Re: [PATCH 4/5] pinctrl: k210: Use devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4450d92-1cea-4051-8906-ace6cd4165a7@kernel.org>
Date: Fri, 30 Aug 2024 13:54:25 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Wang Jianzheng <wangjianzheng@...o.com>,
 Linus Walleij <linus.walleij@...aro.org>,
 "open list:CANAAN/KENDRYTE K210 SOC FPIOA DRIVER"
 <linux-riscv@...ts.infradead.org>,
 "open list:CANAAN/KENDRYTE K210 SOC FPIOA DRIVER"
 <linux-gpio@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH 4/5] pinctrl: k210: Use devm_clk_get_enabled() helpers

On 8/29/24 3:49 PM, Wang Jianzheng wrote:
> The devm_clk_get_enabled() helpers:
>     - call devm_clk_get()
>     - call clk_prepare_enable() and register what is needed in order to
>      call clk_disable_unprepare() when needed, as a managed resource.
> 
> This simplifies the code and avoids the calls to clk_disable_unprepare().
> 
> Signed-off-by: Wang Jianzheng <wangjianzheng@...o.com>

Looks OK to me.

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>

-- 
Damien Le Moal
Western Digital Research