linux-kernel - Re: [PATCH net-next] r8169: add support for RTL8126A rev.b

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2c681d6-2213-4cad-8b01-783ee5f864b0@gmail.com>
Date: Fri, 30 Aug 2024 07:34:05 +0200
From: Heiner Kallweit <hkallweit1@...il.com>
To: ChunHao Lin <hau@...ltek.com>, nic_swsd@...ltek.com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] r8169: add support for RTL8126A rev.b

On 30.08.2024 04:18, ChunHao Lin wrote:
> Add support for RTL8126A rev.b. Its XID is 0x64a. It is basically
> based on the one with XID 0x649, but with different firmware file.
> 
> Signed-off-by: ChunHao Lin <hau@...ltek.com>
> ---
>  drivers/net/ethernet/realtek/r8169.h          |  1 +
>  drivers/net/ethernet/realtek/r8169_main.c     | 42 ++++++++++++-------
>  .../net/ethernet/realtek/r8169_phy_config.c   |  1 +
>  3 files changed, 29 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169.h b/drivers/net/ethernet/realtek/r8169.h
> index 00882ffc7a02..e2db944e6fa8 100644
> --- a/drivers/net/ethernet/realtek/r8169.h
> +++ b/drivers/net/ethernet/realtek/r8169.h
> @@ -69,6 +69,7 @@ enum mac_version {
>  	RTL_GIGA_MAC_VER_61,
>  	RTL_GIGA_MAC_VER_63,
>  	RTL_GIGA_MAC_VER_65,
> +	RTL_GIGA_MAC_VER_66,
>  	RTL_GIGA_MAC_NONE
>  };
>  
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index 3507c2e28110..3cb1c4f5c91a 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -56,6 +56,7 @@
>  #define FIRMWARE_8125A_3	"rtl_nic/rtl8125a-3.fw"
>  #define FIRMWARE_8125B_2	"rtl_nic/rtl8125b-2.fw"
>  #define FIRMWARE_8126A_2	"rtl_nic/rtl8126a-2.fw"
> +#define FIRMWARE_8126A_3	"rtl_nic/rtl8126a-3.fw"
>  

I checked linux-firmware repo, the new firmware isn't available
there yet. Are you going to submit the firmware file?

Reviewed-by: Heiner Kallweit <hkallweit1@...il.com>