linux-kernel - Re: [PATCH v13 04/10] mm: split a folio in minimum folio order chunks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yt9dle0er1s9.fsf@linux.ibm.com>
Date: Fri, 30 Aug 2024 07:57:10 +0200
From: Sven Schnelle <svens@...ux.ibm.com>
To: Luis Chamberlain <mcgrof@...nel.org>
Cc: Zi Yan <ziy@...dia.com>, Matthew Wilcox <willy@...radead.org>,
        "Pankaj
 Raghav (Samsung)" <kernel@...kajraghav.com>,
        brauner@...nel.org, akpm@...ux-foundation.org, chandan.babu@...cle.com,
        linux-fsdevel@...r.kernel.org, djwong@...nel.org, hare@...e.de,
        gost.dev@...sung.com, linux-xfs@...r.kernel.org, hch@....de,
        david@...morbit.com, yang@...amperecomputing.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        john.g.garry@...cle.com, cl@...amperecomputing.com,
        p.raghav@...sung.com, ryan.roberts@....com,
        David Howells
 <dhowells@...hat.com>, linux-s390@...r.kernel.org
Subject: Re: [PATCH v13 04/10] mm: split a folio in minimum folio order chunks

Luis Chamberlain <mcgrof@...nel.org> writes:

> On Thu, Aug 29, 2024 at 06:12:26PM -0400, Zi Yan wrote:
>> The issue is that the change to split_huge_page() makes split_huge_page_to_list_to_order()
>> unlocks the wrong subpage. split_huge_page() used to pass the “page” pointer
>> to split_huge_page_to_list_to_order(), which keeps that “page” still locked.
>> But this patch changes the “page” passed into split_huge_page_to_list_to_order()
>> always to the head page.
>> 
>> This fixes the crash on my x86 VM, but it can be improved:

It also fixes the issue on s390x. Thanks!