linux-kernel - Re: [PATCH] fs: drop GFP_NOFAIL mode from alloc_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4dfed593-5b0c-4565-a6dd-108f1b1fe961@suse.de>
Date: Fri, 30 Aug 2024 08:11:00 +0200
From: Hannes Reinecke <hare@...e.de>
To: Jan Kara <jack@...e.cz>, Michal Hocko <mhocko@...nel.org>
Cc: linux-fsdevel@...r.kernel.org, linux-raid@...r.kernel.org,
 linux-kernel@...r.kernel.org, Song Liu <song@...nel.org>,
 Yu Kuai <yukuai3@...wei.com>, Alexander Viro <viro@...iv.linux.org.uk>,
 Christian Brauner <brauner@...nel.org>, Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH] fs: drop GFP_NOFAIL mode from alloc_page_buffers

On 8/29/24 21:17, Jan Kara wrote:
> On Thu 29-08-24 15:06:40, Michal Hocko wrote:
>> From: Michal Hocko <mhocko@...e.com>
>>
>> There is only one called of alloc_page_buffers and it doesn't require
>> __GFP_NOFAIL so drop this allocation mode.
>>
>> Signed-off-by: Michal Hocko <mhocko@...e.com>
> 
> Looks good. Feel free to add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>
> 
> Although even better fix would be to convert the last remaining caller of
> alloc_page_buffers() to folio_alloc_buffers()... But that may be more
> difficult.
> 
Already done by Pankajs large-block patchset, currently staged in vfs.git.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@...e.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich