linux-kernel - Re: [PATCH V4] scsi: ufs: qcom: update MODE_MAX cfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7v4sgkh5f67hmbrpf4hukgt652qzkgaykszsbzbed44bnh2m7@xaspg6nxxduf>
Date: Fri, 30 Aug 2024 10:20:08 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Manish Pandey <quic_mapa@...cinc.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, 
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, 
	linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, 
	quic_nitirawa@...cinc.com, quic_bhaskarv@...cinc.com, quic_narepall@...cinc.com, 
	quic_rampraka@...cinc.com, quic_cang@...cinc.com, quic_nguyenb@...cinc.com, 
	stable@...r.kernel.org
Subject: Re: [PATCH V4] scsi: ufs: qcom: update MODE_MAX cfg_bw value

On Thu, Aug 29, 2024 at 06:09:38PM GMT, Manish Pandey wrote:
> The cfg_bw value for max mode is incorrect for the Qualcomm SoC.
> Update it to the correct value for cfg_bw max mode.
> 
> Fixes: 03ce80a1bb86 ("scsi: ufs: qcom: Add support for scaling interconnects")
> Cc: stable@...r.kernel.org
> Signed-off-by: Manish Pandey <quic_mapa@...cinc.com>
> ---
> Changes from v3:
> - Cced stable@...r.kernel.org.
> 
> Changes from v2:
> - Addressed Mani comment, added fixes tag.

Mani also asked you to provide details, why the value is considered to
be incorrect. You have responded in the email, but instead those details
should have gone to the commit message. Please fix it accordingly.

> 
> Changes from v1:
> - Updated commit message.
> ---
>  drivers/ufs/host/ufs-qcom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index c87fdc849c62..ecdfff2456e3 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -93,7 +93,7 @@ static const struct __ufs_qcom_bw_table {
>  	[MODE_HS_RB][UFS_HS_G3][UFS_LANE_2] = { 1492582,	204800 },
>  	[MODE_HS_RB][UFS_HS_G4][UFS_LANE_2] = { 2915200,	409600 },
>  	[MODE_HS_RB][UFS_HS_G5][UFS_LANE_2] = { 5836800,	819200 },
> -	[MODE_MAX][0][0]		    = { 7643136,	307200 },
> +	[MODE_MAX][0][0]		    = { 7643136,	819200 },
>  };
>  
>  static void ufs_qcom_get_default_testbus_cfg(struct ufs_qcom_host *host);
> -- 
> 2.17.1
> 

-- 
With best wishes
Dmitry