[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fi47k3icrsgrxwecdsk4ernn7ummi64or4v2sf2njigcjohox7@r3ubyrnev3gu>
Date: Fri, 30 Aug 2024 10:30:14 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Gokul Sriram Palanisamy <quic_gokulsri@...cinc.com>
Cc: andersson@...nel.org, krzk+dt@...nel.org,
linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, quic_viswanat@...cinc.com, quic_mmanikan@...cinc.com,
quic_varada@...cinc.com, quic_srichara@...cinc.com, quic_gokulsri@...conc.com
Subject: Re: [PATCH V2 1/4] dt-bindings: remoteproc: qcom: document hexagon
based WCSS secure PIL
On Thu, Aug 29, 2024 at 07:10:18PM GMT, Gokul Sriram Palanisamy wrote:
> From: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
>
> Add new binding document for hexagon based WCSS secure PIL remoteproc.
> IPQ5332, IPQ9574 follows secure PIL remoteproc.
What is the difference between PAS and secure PIL?
>
> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
> Signed-off-by: Gokul Sriram Palanisamy <quic_gokulsri@...cinc.com>
> ---
> changes since v1: Addressed comments by Krzysztof
> - expanded the acronym WCSS
> - added 'maxItems' to property 'firmware-name'
> - renamed sleep clock name 'im_sleep' to 'sleep'
> - reordered items of property 'qcom,smem-states' keeping 'stop'
> first. Addressed the same in example and in dtsi files.
> - ordered required properties in the same order as property description
> - dropped unused label 'q6v5_wcss' in example dts
>
> .../remoteproc/qcom,wcss-sec-pil.yaml | 125 ++++++++++++++++++
> 1 file changed, 125 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,wcss-sec-pil.yaml
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcss-sec-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcss-sec-pil.yaml
> new file mode 100644
> index 000000000000..98206b403681
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcss-sec-pil.yaml
> @@ -0,0 +1,125 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/remoteproc/qcom,wcss-sec-pil.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm WCSS Secure Peripheral Image Loader
> +
> +maintainers:
> + - Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
> +
> +description:
> + Wireless Connectivity Subsystem (WCSS) Secure Peripheral Image Loader loads
> + firmware and power up QDSP6 remoteproc on the Qualcomm IPQ9574, IPQ5332 SoC.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,ipq5332-wcss-sec-pil
> + - qcom,ipq9574-wcss-sec-pil
> +
> + reg:
> + maxItems: 1
> +
> + firmware-name:
> + maxItems: 1
> + description: Firmware name for the Hexagon core
> +
> + interrupts:
> + items:
> + - description: Watchdog interrupt
> + - description: Fatal interrupt
> + - description: Ready interrupt
> + - description: Handover interrupt
> + - description: Stop acknowledge interrupt
Does it make sense to make use of qcom,pas-common.yaml?
> +
> + interrupt-names:
> + items:
> + - const: wdog
> + - const: fatal
> + - const: ready
> + - const: handover
> + - const: stop-ack
> +
--
With best wishes
Dmitry
Powered by blists - more mailing lists