linux-kernel - Re: [PATCH v1] soc: mediatek: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXv+5HtbAUvC0v5bnJrxD50Tfmb+i1h956-aJkbi+i_BWXcBg@mail.gmail.com>
Date: Fri, 30 Aug 2024 16:33:56 +0900
From: Chen-Yu Tsai <wenst@...omium.org>
To: Yan Zhen <yanzhen@...o.com>
Cc: matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-mediatek@...ts.infradead.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] soc: mediatek: Simplify with dev_err_probe()

On Fri, Aug 30, 2024 at 4:28 PM Yan Zhen <yanzhen@...o.com> wrote:
>
> Using dev_err_probe() to simplify the error path and unify a
> message template.
>
> Using this helper is totally fine even if err is known to never
> be -EPROBE_DEFER.
>
> The benefit compared to a normal dev_err() is the standardized format
> of the error code, it being emitted symbolically and the fact that
> the error code is returned which allows more compact error paths.
>
> Signed-off-by: Yan Zhen <yanzhen@...o.com>
> ---
>  drivers/soc/mediatek/mtk-mmsys.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> index 938240714e54..2f2aefd4d830 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -399,8 +399,7 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
>         mmsys->regs = devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(mmsys->regs)) {
>                 ret = PTR_ERR(mmsys->regs);
> -               dev_err(dev, "Failed to ioremap mmsys registers: %d\n", ret);
> -               return ret;
> +               return dev_err_probe(dev, ret, "Failed to ioremap mmsys registers");

Nit: I would just get rid of `ret` here.

>         }
>
>         mmsys->data = of_device_get_match_data(&pdev->dev);
> @@ -413,10 +412,9 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
>                 mmsys->rcdev.ops = &mtk_mmsys_reset_ops;
>                 mmsys->rcdev.of_node = pdev->dev.of_node;
>                 ret = devm_reset_controller_register(&pdev->dev, &mmsys->rcdev);
> -               if (ret) {
> -                       dev_err(&pdev->dev, "Couldn't register mmsys reset controller: %d\n", ret);
> -                       return ret;
> -               }
> +               if (ret)
> +                       return dev_err_probe(&pdev->dev, ret,
> +                                               "Couldn't register mmsys reset controller");
>         }
>
>         /* CMDQ is optional */
> --
> 2.34.1
>
>