linux-kernel - Re: [PATCH v1] tty: serial: samsung:Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87b15a0c-4bc0-40ee-9f07-991b2dfb9bff@kernel.org>
Date: Fri, 30 Aug 2024 10:00:30 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yu Jiaoliang <yujiaoliang@...o.com>, Alim Akhtar
 <alim.akhtar@...sung.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH v1] tty: serial: samsung:Simplify with dev_err_probe()

On 30/08/2024 05:32, Yu Jiaoliang wrote:
> Error handling in probe() can be a bit simpler with dev_err_probe().
> 
> Signed-off-by: Yu Jiaoliang <yujiaoliang@...o.com>
> ---
>  drivers/tty/serial/samsung_tty.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index c4f2ac9518aa..3550177010ad 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -1225,10 +1225,8 @@ static int s3c64xx_serial_startup(struct uart_port *port)
>  
>  	ret = request_irq(port->irq, s3c64xx_serial_handle_irq, IRQF_SHARED,
>  			  s3c24xx_serial_portname(port), ourport);
> -	if (ret) {
> -		dev_err(port->dev, "cannot get irq %d\n", port->irq);
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(port->dev, port->irq, "cannot get irq\n");

I don't think you really thought this through. First, why changing only
one place, but leaving the rest intact? Are you going to send one patch
per one dev_err_probe()?

Second, that's not even probe path.

NAK

Best regards,
Krzysztof