linux-kernel - Re: [PATCH v2] irqchip: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtGAJ0JnVAUMrG6j@opensource.cirrus.com>
Date: Fri, 30 Aug 2024 09:17:43 +0100
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Yan Zhen <yanzhen@...o.com>
CC: <rf@...nsource.cirrus.com>, <tglx@...utronix.de>,
        <linux-sound@...r.kernel.org>, <patches@...nsource.cirrus.com>,
        <linux-kernel@...r.kernel.org>, <opensource.kernel@...o.com>
Subject: Re: [PATCH v2] irqchip: Simplify with dev_err_probe()

On Fri, Aug 30, 2024 at 03:05:04PM +0800, Yan Zhen wrote:
> Switch to use dev_err_probe() to simplify the error path and
> unify a message template.
> 
> Using this helper is totally fine even if err is known to never
> be -EPROBE_DEFER.
> 
> The benefit compared to a normal dev_err() is the standardized format
> of the error code, it being emitted symbolically and the fact that
> the error code is returned which allows more compact error paths. 
> 
> Signed-off-by: Yan Zhen <yanzhen@...o.com>
> ---

Subject line probably should be irqchip/madera: but otherwise:

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles