linux-kernel - Re: [PATCH] bcachefs: Remove duplicate included headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9cf7c3b9-e9df-43cf-84fc-1e8a790c0763@huawei.com>
Date: Fri, 30 Aug 2024 09:26:56 +0800
From: Hongbo Li <lihongbo22@...wei.com>
To: Thorsten Blum <thorsten.blum@...lux.com>, <kent.overstreet@...ux.dev>
CC: <linux-bcachefs@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bcachefs: Remove duplicate included headers



On 2024/8/29 23:49, Thorsten Blum wrote:
> The header files dirent_format.h and disk_groups_format.h are included
> twice. Remove the redundant includes and the following warnings reported
> by make includecheck:
> 
>    disk_groups_format.h is included more than once
>    dirent_format.h is included more than once
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
> ---
>   fs/bcachefs/bcachefs_format.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/fs/bcachefs/bcachefs_format.h b/fs/bcachefs/bcachefs_format.h
> index 14ce726bf5a3..b97fd0f75831 100644
> --- a/fs/bcachefs/bcachefs_format.h
> +++ b/fs/bcachefs/bcachefs_format.h
> @@ -499,8 +499,6 @@ struct bch_sb_field {
>   #include "disk_groups_format.h"
>   #include "extents_format.h"
>   #include "ec_format.h"
> -#include "dirent_format.h"
> -#include "disk_groups_format.h"

line 497 and line 499.

Reviewed-by: Hongbo Li <lihongbo22@...wei.com>


>   #include "inode_format.h"
>   #include "journal_seq_blacklist_format.h"
>   #include "logged_ops_format.h"