linux-kernel - Re: [PATCH v1] fuse: use min() macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfpeguHFqZF=R=WH2zuECDWHRDD3bYtZGaSrYV-Am0zopbShw@mail.gmail.com>
Date: Fri, 30 Aug 2024 11:29:47 +0200
From: Miklos Szeredi <miklos@...redi.hu>
To: Shen Lichuan <shenlichuan@...o.com>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	opensource.kernel@...o.com
Subject: Re: [PATCH v1] fuse: use min() macro

On Tue, 27 Aug 2024 at 11:19, Shen Lichuan <shenlichuan@...o.com> wrote:
>
> Use the min() macro to simplify the function and improve
> its readability.
>
> Signed-off-by: Shen Lichuan <shenlichuan@...o.com>
> ---
>  fs/fuse/file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 8ead93e775f4..aedeaa6014a6 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -977,7 +977,7 @@ static void fuse_send_readpages(struct fuse_io_args *ia, struct file *file)
>                         return;
>         } else {
>                 res = fuse_simple_request(fm, &ap->args);
> -               err = res < 0 ? res : 0;
> +               err = min(res, 0);


I find it more readable the way it is, because it's not a mathematical
minimum, rather a "if error, return error, otherwise return zero".

Thanks,
Miklos