[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <91d80afc-a911-4932-8f29-5697059efa8d@ti.com>
Date: Fri, 30 Aug 2024 15:40:30 +0530
From: MD Danish Anwar <danishanwar@...com>
To: Roger Quadros <rogerq@...nel.org>,
"David S. Miller"
<davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
<kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Alexei Starovoitov
<ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Jesper Dangaard
Brouer <hawk@...nel.org>,
John Fastabend <john.fastabend@...il.com>,
Julien
Panis <jpanis@...libre.com>,
Jacob Keller <jacob.e.keller@...el.com>
CC: Siddharth Vadapalli <s-vadapalli@...com>,
Vignesh Raghavendra
<vigneshr@...com>,
Govindarajan Sriramakrishnan <srk@...com>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <bpf@...r.kernel.org>
Subject: Re: [PATCH net 0/3] net: ethernet: ti: am65-cpsw: Fix XDP
implementation
On 29/08/24 5:33 pm, Roger Quadros wrote:
> The XDP implementation on am65-cpsw driver is broken in many ways
> and this series fixes it.
>
> Below are the current issues that are being fixed:
>
> 1) The following XDP_DROP test from [1] stalls the interface after
> 250 packets.
> ~# xdb-bench drop -m native eth0
> This is because new RX requests are never queued. Fix that.
>
> 2) The below XDP_TX test from [1] fails with a warning
> [ 499.947381] XDP_WARN: xdp_update_frame_from_buff(line:277): Driver BUG: missing reserved tailroom
> ~# xdb-bench tx -m native eth0
> Fix that by using PAGE_SIZE during xdp_init_buf().
>
> 3) In XDP_REDIRECT case only 1 packet was processed in rx_poll.
> Fix it to process up to budget packets.
> ~# ./xdp-bench redirect -m native eth0 eth0
>
> 4) If number of TX queues are set to 1 we get a NULL pointer
> dereference during XDP_TX.
> ~# ethtool -L eth0 tx 1
> ~# ./xdp-trafficgen udp -A <ipv6-src> -a <ipv6-dst> eth0 -t 2
> Transmitting on eth0 (ifindex 2)
> [ 241.135257] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000030
>
> 5) Net statistics is broken for XDP_TX and XDP_REDIRECT
>
> [1] xdp-tools suite https://github.com/xdp-project/xdp-tools
>
> Signed-off-by: Roger Quadros <rogerq@...nel.org>
This series looks good to me.
Reviewed-by: MD Danish Anwar <danishanwar@...com>
--
Thanks and Regards,
Danish
Powered by blists - more mailing lists